Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2808503003: Fix static initializers in the Chrome OS ResourceReporter. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
afakhry
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix static initializers in the Chrome OS ResourceReporter. BUG=537099 Review-Url: https://codereview.chromium.org/2808503003 Cr-Commit-Position: refs/heads/master@{#462986} Committed: https://chromium.googlesource.com/chromium/src/+/31fbf9fda96d97d53775224b2f8231fb9262a5fc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/browser/chromeos/resource_reporter/resource_reporter.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/resource_reporter/resource_reporter.cc View 4 chunks +16 lines, -17 lines 2 comments Download
M chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
This is from r424855. https://codereview.chromium.org/2808503003/diff/1/chrome/browser/chromeos/resource_reporter/resource_reporter.cc File chrome/browser/chromeos/resource_reporter/resource_reporter.cc (left): https://codereview.chromium.org/2808503003/diff/1/chrome/browser/chromeos/resource_reporter/resource_reporter.cc#oldcode212 chrome/browser/chromeos/resource_reporter/resource_reporter.cc:212: const int64_t ResourceReporter::kTaskMemoryThresholdForReporting = This ...
3 years, 8 months ago (2017-04-07 19:12:43 UTC) #3
afakhry
lgtm, thanks!
3 years, 8 months ago (2017-04-07 20:05:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808503003/1
3 years, 8 months ago (2017-04-07 20:22:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:29:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31fbf9fda96d97d53775224b2f82...

Powered by Google App Engine
This is Rietveld 408576698