Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2808463004: Fix race in WebRtcGetUserMediaBrowserTest (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, jam, darin-cc_chromium.org, Elly Fong-Jones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race in WebRtcGetUserMediaBrowserTest Some test cases raced because each case was changing a global feature flag potentially in parallel. Instead of having separate test cases that each set the flag, have separate tests objects for each value of the flag, and set the flag in the constructor to avoid races. BUG=709112 TBR=hbos@chromium.org Review-Url: https://codereview.chromium.org/2808463004 Cr-Commit-Position: refs/heads/master@{#463130} Committed: https://chromium.googlesource.com/chromium/src/+/270af5af87a83f24a120ac2417bc6ad0aafcca6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+664 lines, -46 lines) Patch
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 7 chunks +664 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808463004/1
3 years, 8 months ago (2017-04-08 08:40:39 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 09:21:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/270af5af87a83f24a120ac2417bc...

Powered by Google App Engine
This is Rietveld 408576698