SPv2: Limit compositor element id application to a single layer.

SPv2: Limit compositor element id application to a single layer.

PropertyTreeState acts as a context that accumulates state as we traverse the
tree building layers. This means that, with current code structure, we could see
a compositor element id 'A' for a parent layer in conjunction with a compositor
element id 'B' for a child layer.

This patch incorporates presence of an id in the set of previously seen
compositor element ids when determining whether the current property tree state
has a compositor element id.

BUG=702350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2808463003
Cr-Commit-Position: refs/heads/master@{#465037}
Committed: https://chromium.googlesource.com/chromium/src/+/ce3c236fb74d87164e5de4a1f8f6fee2f0607f4a

[wkorman, 2017-04-07 20:57:22]

Description was changed from

==========
SPv2: Limit compositor element id application to a single layer.

PropertyTreeState acts as a context that accumulates state as we traverse the
tree building layers. This means that, with current code structure, we could see
a compositor element id 'A' for a parent layer in conjunction with a compositor
element id 'B' for a child layer.

This patch incorporates presence of an id in the set of previously seen
compositor element ids when determining whether the current property tree state
has a compositor element id.

BUG=702350
==========

to

==========
SPv2: Limit compositor element id application to a single layer.

PropertyTreeState acts as a context that accumulates state as we traverse the
tree building layers. This means that, with current code structure, we could see
a compositor element id 'A' for a parent layer in conjunction with a compositor
element id 'B' for a child layer.

This patch incorporates presence of an id in the set of previously seen
compositor element ids when determining whether the current property tree state
has a compositor element id.

BUG=702350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-04-17 18:28:24]

wkorman@chromium.org changed reviewers:
+ jaydasika@chromium.org, pdr@chromium.org

[wkorman, 2017-04-17 18:28:25]

An interim step to improve our current composited animation support as we
prepare to embark on the larger work noted in http://crbug.com/709137.

[wkorman, 2017-04-17 18:28:37]

The CQ bit was checked by wkorman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:28:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-04-17 18:46:06]

On 2017/04/17 at 18:28:25, wkorman wrote:
> An interim step to improve our current composited animation support as we
prepare to embark on the larger work noted in http://crbug.com/709137.

LGTM

Can you add a comment somewhere describing how this works and that this is an
interim solution?

[wkorman, 2017-04-17 18:52:27]

On 2017/04/17 18:46:06, pdr. wrote:
> Can you add a comment somewhere describing how this works and that this is an
> interim solution?

Done, added comment to impl of PropertyTreeState::GetCompositorElementId().

[wkorman, 2017-04-17 20:00:19]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-04-17 20:00:19]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2808463003/#ps80001
(title: "Revise expectations slightly.")

[commit-bot: I haz the power, 2017-04-17 20:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 22:01:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492459219429030,
"parent_rev": "c72acf085d8c0977f28f3e54f4e99cc2cbd55554", "commit_rev":
"ce3c236fb74d87164e5de4a1f8f6fee2f0607f4a"}

[commit-bot: I haz the power, 2017-04-17 22:01:32]

Description was changed from

==========
SPv2: Limit compositor element id application to a single layer.

PropertyTreeState acts as a context that accumulates state as we traverse the
tree building layers. This means that, with current code structure, we could see
a compositor element id 'A' for a parent layer in conjunction with a compositor
element id 'B' for a child layer.

This patch incorporates presence of an id in the set of previously seen
compositor element ids when determining whether the current property tree state
has a compositor element id.

BUG=702350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
SPv2: Limit compositor element id application to a single layer.

PropertyTreeState acts as a context that accumulates state as we traverse the
tree building layers. This means that, with current code structure, we could see
a compositor element id 'A' for a parent layer in conjunction with a compositor
element id 'B' for a child layer.

This patch incorporates presence of an id in the set of previously seen
compositor element ids when determining whether the current property tree state
has a compositor element id.

BUG=702350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2808463003
Cr-Commit-Position: refs/heads/master@{#465037}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce3c236fb74d87164e5de4a1f8f6...
==========

[commit-bot: I haz the power, 2017-04-17 22:01:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ce3c236fb74d87164e5de4a1f8f6...