Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2808433003: [Sync] Delete dead code from sync_scheduler_impl (Closed)

Created:
3 years, 8 months ago by skym
Modified:
3 years, 8 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Delete dead code from sync_scheduler_impl BUG= Review-Url: https://codereview.chromium.org/2808433003 Cr-Commit-Position: refs/heads/master@{#463277} Committed: https://chromium.googlesource.com/chromium/src/+/d3b51db01c5c3bf3d2e904baf17f4302a77a7156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -41 lines) Patch
M components/sync/engine_impl/sync_scheduler_impl.h View 4 chunks +1 line, -17 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.cc View 3 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skym
PTAL
3 years, 8 months ago (2017-04-07 22:29:49 UTC) #4
pavely
lgtm
3 years, 8 months ago (2017-04-07 22:34:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808433003/1
3 years, 8 months ago (2017-04-10 14:46:41 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:47:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3b51db01c5c3bf3d2e904baf17f...

Powered by Google App Engine
This is Rietveld 408576698