Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2808413003: Omnibox - Reduce Clipboard URL Suggestions to 1 Hour (Closed)
Patch Set: cleanup field trial.h Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/open_from_clipboard/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index 2409711b18e74acf5538f06890b3bae1e0e47138..d0bf1d80a2ad665969675cccfd3ba5ee9c84c3fa 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -426,6 +426,17 @@ class OmniboxFieldTrial {
static std::string ZeroSuggestRedirectToChromeAdditionalFields();
// ---------------------------------------------------------
+ // Clipboard URL suggestions:
+
+ // One parameter for the omnibox field trial that doesn't live in this file;
Peter Kasting 2017/04/12 20:02:30 Nit: Remove "that"
Mark P 2017/04/12 21:56:59 Done.
+ // instead it lives in
+ // components/open_from_clipboard/clipboard_recent_content.cc.
+ // This is because that component cannot include this component, else there
+ // would be a circular dependency. Please see ClipboardRecentContent::
+ // MaximumAgeOfClipboard() for the usage of that parameter, named
+ // "ClipboardURLMaximumAge".
Peter Kasting 2017/04/12 20:02:30 Nit: Name the parameter at the beginning of the co
Mark P 2017/04/12 21:56:59 Reorganized and rewrote. Take a gander.
+
+ // ---------------------------------------------------------
// Exposed publicly for the sake of unittests.
static const char kBundledExperimentFieldTrialName[];
// Rule names used by the bundled experiment.
« no previous file with comments | « no previous file | components/open_from_clipboard/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698