Omnibox - Reduce Clipboard URL Suggestions to 1 Hour

components/omnibox/browser/omnibox_field_trial.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 #define COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 408 matching lines @@
   // (no "?").
   static std::string ZeroSuggestRedirectToChromeServerAddress();
 
   // Returns a string representing the parameters that are sent to the
   // alternative service providing zero suggestions. The returned value is
   // properly escaped. It can be appended to the string representaiton of a
   // request URL.
   static std::string ZeroSuggestRedirectToChromeAdditionalFields();
 
   // ---------------------------------------------------------
+  // Clipboard URL suggestions:
+
+  // One parameter for the omnibox field trial that doesn't live in this file;

[Peter Kasting, 2017/04/12 20:02:30]

Nit: Remove "that"

[Mark P, 2017/04/12 21:56:59]

Done.

+  // instead it lives in
+  // components/open_from_clipboard/clipboard_recent_content.cc.
+  // This is because that component cannot include this component, else there
+  // would be a circular dependency.  Please see ClipboardRecentContent::
+  // MaximumAgeOfClipboard() for the usage of that parameter, named
+  // "ClipboardURLMaximumAge".

[Peter Kasting, 2017/04/12 20:02:30]

Nit: Name the parameter at the beginning of the comment, then say why it can't
live here.  (This is sort of the paragraph structure version of "don't use
passive voice".)

[Mark P, 2017/04/12 21:56:59]

Reorganized and rewrote.  Take a gander.

+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kDisableProvidersRule[];
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPTypedValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
@@ skipping 69 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_FIELD_TRIAL_H_