Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2808413002: Rename Layer::screen_space_transform to Layer::ScreenSpaceTransform (Closed)

Created:
3 years, 8 months ago by xidachen
Modified:
3 years, 8 months ago
Reviewers:
jbroman, enne (OOO)
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Layer::screen_space_transform to Layer::ScreenSpaceTransform We already have LayerImpl::ScreenSpaceTransform that does the same thing, so the screen_space_transform in layer.h should be renamed to match the style. This CL is a pure style fix, no behavior change. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2808413002 Cr-Commit-Position: refs/heads/master@{#463780} Committed: https://chromium.googlesource.com/chromium/src/+/41fb39bbab83396812415b5b303c3ca7b47c2bd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M cc/benchmarks/invalidation_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 14 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xidachen
On 2017/04/11 15:57:41, xidachen wrote: > mailto:xidachen@chromium.org changed reviewers: > + mailto:enne@chromium.org, mailto:jbroman@chromium.org +jbroman@ for ...
3 years, 8 months ago (2017-04-11 15:58:32 UTC) #5
jbroman
third_party/WebKit/ lgtm
3 years, 8 months ago (2017-04-11 17:08:10 UTC) #6
enne (OOO)
lgtm
3 years, 8 months ago (2017-04-11 17:11:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808413002/1
3 years, 8 months ago (2017-04-11 20:27:42 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:41:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41fb39bbab83396812415b5b303c...

Powered by Google App Engine
This is Rietveld 408576698