Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2808403009: MD Settings: Don't search dynamic download location text. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Don't search dynamic download location text. This matches old Options behavior, and side steps the problem of showing an obsolete download location value, if the user changes download location while a search highlight is being displayed. BUG=711156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2808403009 Cr-Commit-Position: refs/heads/master@{#464484} Committed: https://chromium.googlesource.com/chromium/src/+/f19ae8a724c71178e3ab46dd2e0955f72cd0adb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dpapad
Before/after screenshots at http://imgur.com/a/eOTVJ. Bug explanation: See comment#1 and #2 in linked bug.
3 years, 8 months ago (2017-04-13 17:40:11 UTC) #4
tommycli
lgtm i'm down
3 years, 8 months ago (2017-04-13 17:42:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808403009/1
3 years, 8 months ago (2017-04-13 17:46:54 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 18:57:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f19ae8a724c71178e3ab46dd2e09...

Powered by Google App Engine
This is Rietveld 408576698