[Home] Bottom page info

[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL). The max height of the bottom popup is 48dp from
the top of the screen (the minimum touch target). This is only an
issue for excessively long URLs.

BUG=711096
Review-Url: https://codereview.chromium.org/2808403008
Cr-Commit-Position: refs/heads/master@{#465013}
Committed: https://chromium.googlesource.com/chromium/src/+/5f80068e69638cd89296ee95d4253c624ee86f76

[mdjones, 2017-04-14 21:59:26]

Description was changed from

==========
[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL).

BUG=711096
==========

to

==========
[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL). The max height of the bottom popup is 48dp from
the top of the screen (the minimum touch target). This is only an
issue for excessively long URLs.

BUG=711096
==========

[mdjones, 2017-04-14 21:59:37]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-04-14 21:59:38]

ptal

[Theresa, 2017-04-14 22:13:34]

lgtm

[mdjones, 2017-04-14 22:20:30]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-04-14 22:20:30]

dfalcantara: owner

[gone, 2017-04-17 20:05:53]

lgtm

[mdjones, 2017-04-17 20:18:15]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:18:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:56:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492460295166470,
"parent_rev": "2c96514f650b4db1f6abebf0d6b307d65bca3e5b", "commit_rev":
"5f80068e69638cd89296ee95d4253c624ee86f76"}

[commit-bot: I haz the power, 2017-04-17 20:57:02]

Description was changed from

==========
[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL). The max height of the bottom popup is 48dp from
the top of the screen (the minimum touch target). This is only an
issue for excessively long URLs.

BUG=711096
==========

to

==========
[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL). The max height of the bottom popup is 48dp from
the top of the screen (the minimum touch target). This is only an
issue for excessively long URLs.

BUG=711096

Review-Url: https://codereview.chromium.org/2808403008
Cr-Commit-Position: refs/heads/master@{#465013}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f80068e69638cd89296ee95d425...
==========

[commit-bot: I haz the power, 2017-04-17 20:57:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f80068e69638cd89296ee95d425...