Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2808403006: [regexp] Fix incorrect DCHECK in FixSingleCharacterDisjunctions (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix incorrect DCHECK in FixSingleCharacterDisjunctions The condition only applies in unicode mode, where any lone surrogates are desugared into a character class (and will not be considered in this optimization). Non-unicode mode treats lone surrogates exactly like any other codepoint. BUG=chromium:711092 Review-Url: https://codereview.chromium.org/2808403006 Cr-Commit-Position: refs/heads/master@{#44638} Committed: https://chromium.googlesource.com/v8/v8/+/876e23c54d5fa2cb2a399632175d94e597da5330

Patch Set 1 #

Patch Set 2 : Tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/regexp/jsregexp.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M test/mjsunit/regexp.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jgruber
3 years, 8 months ago (2017-04-13 09:17:32 UTC) #4
Yang
On 2017/04/13 09:17:32, jgruber wrote: lgtm
3 years, 8 months ago (2017-04-13 10:25:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808403006/20001
3 years, 8 months ago (2017-04-13 10:31:20 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 10:33:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/876e23c54d5fa2cb2a399632175d94e597d...

Powered by Google App Engine
This is Rietveld 408576698