Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2808403003: Import XMLHttpRequest wpt tests. (Closed)

Created:
3 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Import XMLHttpRequest wpt tests. Some Fetch API tests require bits from the /XMLHttpRequest directory. Some of the tests are also required for correctly testing behavior after changes to the Fetch and XHR specs. BUG=687155, 705490 R=falken@chromium.org,tyoshino@chromium.org,yhirano@chromium.org Review-Url: https://codereview.chromium.org/2808403003 Cr-Commit-Position: refs/heads/master@{#464024} Committed: https://chromium.googlesource.com/chromium/src/+/5bc8d44f3ab226674d0dd2c52ef631d6d52dc464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Raphael Kubo da Costa (rakuco)
PTAL I think several tests aren't passing yet, but the WPT importer should take care ...
3 years, 8 months ago (2017-04-12 10:36:23 UTC) #1
falken
lgtm if this is the way to import
3 years, 8 months ago (2017-04-12 14:43:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808403003/1
3 years, 8 months ago (2017-04-12 15:00:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5bc8d44f3ab226674d0dd2c52ef631d6d52dc464
3 years, 8 months ago (2017-04-12 15:07:26 UTC) #12
tyoshino (SeeGerritForStatus)
3 years, 7 months ago (2017-05-11 07:14:02 UTC) #13
Message was sent while issue was closed.
late lgtm

Yes, this is the right way. Thanks.

Powered by Google App Engine
This is Rietveld 408576698