Remove invalid DCHECK in [CRWSessionController addPendingItem].

Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added
to the chain.

This CL removes the DCHECK.

BUG=710385
Review-Url: https://codereview.chromium.org/2808353007
Cr-Commit-Position: refs/heads/master@{#464310}
Committed: https://chromium.googlesource.com/chromium/src/+/a4eb8e01f972546913b22a605e31bd22c270cfe8

[liaoyuke, 2017-04-12 22:13:27]

Description was changed from

==========
remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

This CL removes the DCHECK.

BUG=710385
==========

to

==========
Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

This CL removes the DCHECK.

BUG=710385
==========

[liaoyuke, 2017-04-12 22:13:27]

liaoyuke@chromium.org changed reviewers:
+ eugenebut@chromium.org, kkhorimoto@chromium.org

[liaoyuke, 2017-04-12 22:14:08]

Hey Eugene, Kurt

PTAL.

Thank you very much!

[Eugene But (OOO till 7-30), 2017-04-13 00:27:12]

Please update CL description to explain why this DCHECK is invalid (on restore
there is no pending item, so redirect is added to the chain). lgtm

[kkhorimoto, 2017-04-13 01:18:24]

lgtm

[liaoyuke, 2017-04-13 05:13:36]

Description was changed from

==========
Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

This CL removes the DCHECK.

BUG=710385
==========

to

==========
Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added 
to the chain.

This CL removes the DCHECK.

BUG=710385
==========

[liaoyuke, 2017-04-13 05:14:37]

The CQ bit was checked by liaoyuke@chromium.org

[commit-bot: I haz the power, 2017-04-13 05:14:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 05:31:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492060477136920, "parent_rev":
"77065d9816b34a5cc7913894b8b756e7c3e6fb79", "commit_rev":
"a4eb8e01f972546913b22a605e31bd22c270cfe8"}

[commit-bot: I haz the power, 2017-04-13 05:39:46]

Description was changed from

==========
Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added 
to the chain.

This CL removes the DCHECK.

BUG=710385
==========

to

==========
Remove invalid DCHECK in [CRWSessionController addPendingItem].

The DCHCECK that server side redirect should not be added as a new item
is invalid in the following scenario:

(1) Navigate to an AMP (Accelerate Mobile Page) -- I do this from
    news.google.fr
(2) Shutdown Chrome on iOS (i.e. switch to another app, then kill the
    app)
(3) Relaunch Chrome on iOS

When Chrome is relaunched, there will be no pending items and somehow a
server side redirect is fired, so a server side redirect item is added
to the chain.

This CL removes the DCHECK.

BUG=710385

Review-Url: https://codereview.chromium.org/2808353007
Cr-Commit-Position: refs/heads/master@{#464310}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4eb8e01f972546913b22a605e31...
==========

[commit-bot: I haz the power, 2017-04-13 05:39:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4eb8e01f972546913b22a605e31...