Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 2808353005: Make offscreen canvas resizing test deterministic (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make offscreen canvas resizing test deterministic Similarly to https://codereview.chromium.org/2738773004, two more calls to commit() should be amended with a nested timer trampoline to make sure the commit has completed before we read the results. BUG=696001, 709484 Review-Url: https://codereview.chromium.org/2808353005 Cr-Commit-Position: refs/heads/master@{#464017} Committed: https://chromium.googlesource.com/chromium/src/+/b10caf8de873181849d28ea10bea9be564875e31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-resize.html View 2 chunks +47 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sami
PTAL.
3 years, 8 months ago (2017-04-12 13:04:14 UTC) #3
Justin Novosad
On 2017/04/12 13:04:14, Sami wrote: > PTAL. lgtm
3 years, 8 months ago (2017-04-12 14:18:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808353005/1
3 years, 8 months ago (2017-04-12 14:18:29 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 14:29:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b10caf8de873181849d28ea10bea...

Powered by Google App Engine
This is Rietveld 408576698