bluetooth: Rename Is*Available to Is*Supported

bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG=710756
Review-Url: https://codereview.chromium.org/2808353004
Cr-Commit-Position: refs/heads/master@{#465844}
Committed: https://chromium.googlesource.com/chromium/src/+/57ed4544b704badc3e547fc87b06b4ddcabe2869

[ortuno, 2017-04-12 07:17:01]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 07:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 07:29:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2017-04-12 08:43:56]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 08:44:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 09:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 09:16:51]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[ortuno, 2017-04-12 23:53:37]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 23:54:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 00:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:34:30]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[ortuno, 2017-04-13 01:50:34]

Patchset #1 (id:1) has been deleted

[ortuno, 2017-04-13 01:50:39]

Patchset #1 (id:20001) has been deleted

[ortuno, 2017-04-13 01:50:44]

Patchset #1 (id:40001) has been deleted

[ortuno, 2017-04-13 01:51:22]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 01:52:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-04-13 01:52:20]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2017-04-13 01:52:21]

scheib: PTAL

[Kyle Horimoto, 2017-04-13 01:55:35]

khorimoto@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Kyle Horimoto, 2017-04-13 01:55:36]

https://codereview.chromium.org/2808353004/diff/60001/chromeos/components/tet...
File chromeos/components/tether/initializer.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/chromeos/components/tet...
chromeos/components/tether/initializer.cc:55: PA_LOG(WARNING) << "Bluetooth is
unavailable on this device; cannot "
nit: Change log as well.

[commit-bot: I haz the power, 2017-04-13 03:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:12:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2017-04-13 05:06:26]

https://codereview.chromium.org/2808353004/diff/60001/components/pairing/blue...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/components/pairing/blue...
components/pairing/bluetooth_host_pairing_controller.cc:474: bool
bluetooth_available =
var name

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:83: return base::win::GetVersion()
>= base::win::VERSION_WIN8;
Will we get in trouble with 8 level being supported for everything but
connection?

[ortuno, 2017-04-18 01:22:27]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-04-18 01:25:42]

https://codereview.chromium.org/2808353004/diff/60001/chromeos/components/tet...
File chromeos/components/tether/initializer.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/chromeos/components/tet...
chromeos/components/tether/initializer.cc:55: PA_LOG(WARNING) << "Bluetooth is
unavailable on this device; cannot "
On 2017/04/13 at 01:55:36, Kyle Horimoto wrote:
> nit: Change log as well.

Done.

https://codereview.chromium.org/2808353004/diff/60001/components/pairing/blue...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/components/pairing/blue...
components/pairing/bluetooth_host_pairing_controller.cc:474: bool
bluetooth_available =
On 2017/04/13 at 05:06:25, scheib wrote:
> var name

Done.

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:83: return base::win::GetVersion()
>= base::win::VERSION_WIN8;
On 2017/04/13 at 05:06:25, scheib wrote:
> Will we get in trouble with 8 level being supported for everything but
connection?

And scanning! I kept the support at 8 to reflect our current support. When
Windows work starts ramping up we can decide if we want to keep supporting Win 8
and if so how to account for the missing features. This puts us at risk of
having to maintain the API on Win 8 if a new client expects it but the odds of
this are very low imo.

[commit-bot: I haz the power, 2017-04-18 03:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:01:15]

Dry run: This issue passed the CQ dry run.

[scheib, 2017-04-18 03:38:41]

lgtm

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:83: return base::win::GetVersion()
>= base::win::VERSION_WIN8;
On 2017/04/18 01:25:42, ortuno wrote:
> On 2017/04/13 at 05:06:25, scheib wrote:
> > Will we get in trouble with 8 level being supported for everything but
> connection?
> 
> And scanning! I kept the support at 8 to reflect our current support. When
> Windows work starts ramping up we can decide if we want to keep supporting Win
8
> and if so how to account for the missing features. This puts us at risk of
> having to maintain the API on Win 8 if a new client expects it but the odds of
> this are very low imo.

/shrug/ I would go with 10 now. But, your call.

[ortuno, 2017-04-18 07:05:34]

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/2808353004/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:83: return base::win::GetVersion()
>= base::win::VERSION_WIN8;
On 2017/04/18 at 03:38:41, scheib wrote:
> On 2017/04/18 01:25:42, ortuno wrote:
> > On 2017/04/13 at 05:06:25, scheib wrote:
> > > Will we get in trouble with 8 level being supported for everything but
> > connection?
> > 
> > And scanning! I kept the support at 8 to reflect our current support. When
> > Windows work starts ramping up we can decide if we want to keep supporting
Win 8
> > and if so how to account for the missing features. This puts us at risk of
> > having to maintain the API on Win 8 if a new client expects it but the odds
of
> > this are very low imo.
> 
> /shrug/ I would go with 10 now. But, your call.

Increased to win 10 and added a note as to why we don't support win8.

[ortuno, 2017-04-18 07:13:45]

ortuno@chromium.org changed reviewers:
+ achuith@chromium.org, lhchavez@chromium.org, rockot@chromium.org,
tbarzic@chromium.org

[ortuno, 2017-04-18 07:13:46]

lhchavez: PTAL at arc/
tbarzic: PTAL at chrome/browser/signin/easy_unlock, components/proximity_auth/
khorimoto: PTAL at tether/
achuith: PTAL at compoments/pairing/
rockot: PTAL at extensions/browser/ (fyi rkc is cc'ed)

[ortuno, 2017-04-18 07:13:52]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 07:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2017-04-18 07:38:58]

components/pairing lgtm

https://codereview.chromium.org/2808353004/diff/100001/components/pairing/blu...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2808353004/diff/100001/components/pairing/blu...
components/pairing/bluetooth_host_pairing_controller.cc:474: bool
bluetooth_supported =
nit: const

[commit-bot: I haz the power, 2017-04-18 08:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 08:47:21]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-04-18 21:23:18]

*/arc/* lgtm

[Ken Rockot(use gerrit already), 2017-04-18 21:46:24]

rs lgtm

[tbarzic, 2017-04-18 22:02:39]

lgtm

[Kyle Horimoto, 2017-04-19 22:28:33]

lgtm

[ortuno, 2017-04-19 23:19:43]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-04-19 23:19:44]

Thanks all.

https://codereview.chromium.org/2808353004/diff/100001/components/pairing/blu...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2808353004/diff/100001/components/pairing/blu...
components/pairing/bluetooth_host_pairing_controller.cc:474: bool
bluetooth_supported =
On 2017/04/18 at 07:38:57, achuithb wrote:
> nit: const

Done.

[ortuno, 2017-04-19 23:19:45]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
rockot@chromium.org, lhchavez@chromium.org, khorimoto@chromium.org,
achuith@chromium.org, tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/2808353004/#ps120001
(title: "Add const")

[ortuno, 2017-04-19 23:20:06]

Description was changed from

==========
bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames the IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG=710756
==========

to

==========
bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG=710756
==========

[commit-bot: I haz the power, 2017-04-19 23:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:16:33]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492643983684740,
"parent_rev": "1f5b91b54c1650e14277f39dc1baa1ff096c75b6", "commit_rev":
"57ed4544b704badc3e547fc87b06b4ddcabe2869"}

[commit-bot: I haz the power, 2017-04-20 01:17:22]

Description was changed from

==========
bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG=710756
==========

to

==========
bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG=710756

Review-Url: https://codereview.chromium.org/2808353004
Cr-Commit-Position: refs/heads/master@{#465844}
Committed:
https://chromium.googlesource.com/chromium/src/+/57ed4544b704badc3e547fc87b06...
==========

[commit-bot: I haz the power, 2017-04-20 01:17:25]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/57ed4544b704badc3e547fc87b06...