Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2808333004: MD Bookmarks: Improve test coverage for Actions and Routing (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Improve test coverage for Actions and Routing This adds a new test file for tests of actions, and changes how routing tests are run so that it is possible to add new tests for routing initialization without adding a new browser test for each URL to be tested. BUG=697706 Review-Url: https://codereview.chromium.org/2808333004 Cr-Commit-Position: refs/heads/master@{#463946} Committed: https://chromium.googlesource.com/chromium/src/+/d328a8fc03fdbdf4fbe0c74652108f2c28436cff

Patch Set 1 #

Patch Set 2 : Remove .only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -72 lines) Patch
A chrome/test/data/webui/md_bookmarks/actions_test.js View 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/list_test.js View 1 chunk +7 lines, -37 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js View 2 chunks +15 lines, -19 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/router_test.js View 1 3 chunks +55 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tsergeant
PTAL, I figured it made sense to pull these out into their own CL.
3 years, 8 months ago (2017-04-12 01:28:59 UTC) #4
calamity
lgtm
3 years, 8 months ago (2017-04-12 04:16:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808333004/20001
3 years, 8 months ago (2017-04-12 06:02:05 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 07:47:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d328a8fc03fdbdf4fbe0c7465210...

Powered by Google App Engine
This is Rietveld 408576698