Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2808333003: Fix for the "Always Show Toolbar in Full Screen" Menu Item (Closed)

Created:
3 years, 8 months ago by spqchan
Modified:
3 years, 8 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for the "Always Show Toolbar in Full Screen" Menu Item BUG=706634 Review-Url: https://codereview.chromium.org/2808333003 Cr-Commit-Position: refs/heads/master@{#463851} Committed: https://chromium.googlesource.com/chromium/src/+/f1a29ebf18d1e876df019c862c9e4f6719aff64f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
spqchan
PTAL
3 years, 8 months ago (2017-04-11 23:12:08 UTC) #3
ccameron
lgtm
3 years, 8 months ago (2017-04-11 23:28:37 UTC) #4
spqchan
On 2017/04/11 23:28:37, ccameron wrote: > lgtm thanks!
3 years, 8 months ago (2017-04-11 23:35:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808333003/1
3 years, 8 months ago (2017-04-11 23:35:56 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 00:13:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1a29ebf18d1e876df019c862c9e...

Powered by Google App Engine
This is Rietveld 408576698