Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 280833003: <webview>: Move Color Chooser and File Chooser to Chrome (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
lazyboy, jam
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_downloads_to_chorme
Visibility:
Public.

Description

<webview>: Move Color Chooser and File Chooser to Chrome BUG=364141, 330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M chrome/browser/guest_view/web_view/web_view_guest.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 2 chunks +18 lines, -1 line 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-13 17:59:00 UTC) #1
lazyboy
lgtm
6 years, 7 months ago (2014-05-13 18:06:20 UTC) #2
Fady Samuel
6 years, 7 months ago (2014-05-13 19:14:27 UTC) #3
jam
I don't understand the purpose of this cl. Can you provide the motivation?
6 years, 7 months ago (2014-05-13 20:14:05 UTC) #4
jam
Fady explained on chat, lgtm
6 years, 7 months ago (2014-05-13 20:48:32 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-14 01:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/280833003/1
6 years, 7 months ago (2014-05-14 01:03:09 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 05:51:58 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 06:44:43 UTC) #9
Message was sent while issue was closed.
Change committed as 270348

Powered by Google App Engine
This is Rietveld 408576698