chrome/browser/guest_view/web_view/web_view_guest.h - Issue 280833003: <webview>: Move Color Chooser and File Chooser to Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 280833003: <webview>: Move Color Chooser and File Chooser to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_downloads_to_chorme

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guest_view/web_view/web_view_guest.h

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h

index 37557bfd2ce7a75355cecd7fe2008c5b19fb6781..f3e7898847af48159b8c664cf91582d67a39b509 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.h

+++ b/chrome/browser/guest_view/web_view/web_view_guest.h

@@ -114,6 +114,13 @@ class WebViewGuest : public GuestView<WebViewGuest>,

const base::Callback<void(bool)>& callback) OVERRIDE;

virtual content::JavaScriptDialogManager*

GetJavaScriptDialogManager() OVERRIDE;

+ virtual content::ColorChooser* OpenColorChooser(

+ content::WebContents* web_contents,

+ SkColor color,

+ const std::vector<content::ColorSuggestion>& suggestions) OVERRIDE;

+ virtual void RunFileChooser(

+ content::WebContents* web_contents,

+ const content::FileChooserParams& params) OVERRIDE;

// NotificationObserver implementation.

virtual void Observe(int type,

« no previous file with comments | « no previous file | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »