Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2808293003: Sync confirmation: hide extraneous checkbox ripple on early focus (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync confirmation: hide extraneous checkbox ripple on early focus Only happens on Mac due to platform-specific focus logic I don't really want to dive into that much. R=tommycli@chromium.org BUG=710291 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2808293003 Cr-Commit-Position: refs/heads/master@{#463643} Committed: https://chromium.googlesource.com/chromium/src/+/ee6794b5b8e7c06965106741ada8d94beedf98cc

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Dan Beam
3 years, 8 months ago (2017-04-11 05:57:03 UTC) #4
tommycli
lgtm. Weird. but does the trick (had to dig fairly deep to understand this one)
3 years, 8 months ago (2017-04-11 15:36:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808293003/20001
3 years, 8 months ago (2017-04-11 15:50:19 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 15:57:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee6794b5b8e7c06965106741ada8...

Powered by Google App Engine
This is Rietveld 408576698