Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2746)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2808283003: Fix Bookmarks bubble title misalignment. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 0e8c261e3a902436d472a5d049443203c147a18e..2d3be5db1be69acba1fd69e479a8a401112310bb 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -303,7 +303,14 @@ BookmarkBubbleView::BookmarkBubbleView(
ios_promo_view_(nullptr),
remove_bookmark_(false),
apply_edits_(true),
- is_showing_ios_promotion_(false) {}
+ is_showing_ios_promotion_(false) {
+ // Set title margins to make the title and the content left aligned.
+ const int side_margin = margins().left();
+ set_title_margins(
+ gfx::Insets(LayoutDelegate::Get()->GetMetric(
+ LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),
+ side_margin, 0, side_margin));
Peter Kasting 2017/04/11 20:26:29 Are the title and content misaligned on other simi
mrefaat1 2017/04/11 20:44:02 i'm not sure if its a problem on different dialogs
Peter Kasting 2017/04/11 20:57:05 Where is this passwords-specific fix? Did it land
mrefaat 2017/04/12 18:43:23 this is the specific fix: https://chromium.googles
+}
base::string16 BookmarkBubbleView::GetTitle() {
BookmarkModel* bookmark_model =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698