Fix Bookmarks bubble title misalignment.

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/metrics/user_metrics.h"
@@ skipping 285 matching lines @@
                     BookmarkModelFactory::GetForBrowserContext(profile_)
                         ->GetMostRecentlyAddedUserNodeForURL(url)),
       remove_button_(nullptr),
       edit_button_(nullptr),
       close_button_(nullptr),
       title_tf_(nullptr),
       parent_combobox_(nullptr),
       ios_promo_view_(nullptr),
       remove_bookmark_(false),
       apply_edits_(true),
-      is_showing_ios_promotion_(false) {}
+      is_showing_ios_promotion_(false) {
+  // Set title margins to make the title and the content left aligned.
+  const int side_margin = margins().left();
+  set_title_margins(
+      gfx::Insets(LayoutDelegate::Get()->GetMetric(
+                      LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),
+                  side_margin, 0, side_margin));

[Peter Kasting, 2017/04/11 20:26:29]

Are the title and content misaligned on other similar dialogs?  If so, this fix
doesn't seem correct because it only adjusts bookmarks.  If not, why are other
places correct but this one isn't?

[mrefaat1, 2017/04/11 20:44:02]

i'm not sure if its a problem on different dialogs, But it was broken on
Passwords dialog and someone also sent a fix that does the same thing (only on
the passwords) i'd definite prefer to have a fix for all bubbles - But if this
is going to be fixed with harmony is it worth it to do a fix ? 

[Peter Kasting, 2017/04/11 20:57:05]

Where is this passwords-specific fix?  Did it land?  If so let's back it out and
fix in a more global fashion.

We should definitely fix this stuff now, pre-Harmony, because Harmony assumes
the existing behavior is correct and tries to refactor and modify code based on
that.  If the existing behavior is wrong, we're going to be really confused.

[mrefaat, 2017/04/12 18:43:23]

this is the specific fix:
https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e...
- it did land and was merged to 58 too.

+}
 
 base::string16 BookmarkBubbleView::GetTitle() {
   BookmarkModel* bookmark_model =
       BookmarkModelFactory::GetForBrowserContext(profile_);
   const BookmarkNode* node =
       bookmark_model->GetMostRecentlyAddedUserNodeForURL(url_);
   if (node)
     return node->GetTitle();
   else
     NOTREACHED();
@@ skipping 90 matching lines @@
   RemoveChildView(bookmark_details_view_.get());
   is_showing_ios_promotion_ = true;
   ios_promo_view_ = new DesktopIOSPromotionBubbleView(
       profile_, desktop_ios_promotion::PromotionEntryPoint::BOOKMARKS_BUBBLE);
   AddChildView(ios_promo_view_);
   GetWidget()->UpdateWindowIcon();
   GetWidget()->UpdateWindowTitle();
   SizeToContents();
 }
 #endif