Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: remoting/protocol/ice_transport_unittest.cc

Issue 2808283002: Improve tests for Mixed-Case JIDs. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/ice_transport_unittest.cc
diff --git a/remoting/protocol/ice_transport_unittest.cc b/remoting/protocol/ice_transport_unittest.cc
index ccb3d8de96610a7f7d5357ddc1f0b89658c05fc9..cf9a89577be53aad1c7656b1181e6593d6cd36b8 100644
--- a/remoting/protocol/ice_transport_unittest.cc
+++ b/remoting/protocol/ice_transport_unittest.cc
@@ -122,20 +122,15 @@ class IceTransportTest : public testing::Test {
base::MakeUnique<ChromiumPortAllocatorFactory>(),
nullptr, network_settings_, TransportRole::SERVER),
&host_event_handler_));
- if (!host_authenticator_) {
- host_authenticator_.reset(new FakeAuthenticator(
- FakeAuthenticator::HOST, 0, FakeAuthenticator::ACCEPT, true));
- }
+ host_authenticator_.reset(new FakeAuthenticator(FakeAuthenticator::ACCEPT));
client_transport_.reset(new IceTransport(
new TransportContext(nullptr,
base::MakeUnique<ChromiumPortAllocatorFactory>(),
nullptr, network_settings_, TransportRole::CLIENT),
&client_event_handler_));
- if (!client_authenticator_) {
- client_authenticator_.reset(new FakeAuthenticator(
- FakeAuthenticator::CLIENT, 0, FakeAuthenticator::ACCEPT, true));
- }
+ client_authenticator_.reset(
+ new FakeAuthenticator(FakeAuthenticator::ACCEPT));
host_event_handler_.set_error_callback(base::Bind(
&IceTransportTest::OnTransportError, base::Unretained(this)));
@@ -247,8 +242,8 @@ TEST_F(IceTransportTest, MuxDataStream) {
TEST_F(IceTransportTest, FailedChannelAuth) {
// Use host authenticator with one that rejects channel authentication.
- host_authenticator_.reset(new FakeAuthenticator(
- FakeAuthenticator::HOST, 0, FakeAuthenticator::REJECT_CHANNEL, true));
+ host_authenticator_.reset(
+ new FakeAuthenticator(FakeAuthenticator::REJECT_CHANNEL));
InitializeConnection();

Powered by Google App Engine
This is Rietveld 408576698