Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2808273005: Make plugins/plugin-reload-data.html deterministic (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
Reviewers:
Eric Seckler
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make plugins/plugin-reload-data.html deterministic After changing the data property of a plugin, we should wait for a notification from the plugin confirming the new data before exiting the test. BUG=696001 Review-Url: https://codereview.chromium.org/2808273005 Cr-Commit-Position: refs/heads/master@{#463995} Committed: https://chromium.googlesource.com/chromium/src/+/a979e581c8d1585cb67062d29f9ef25ffcbe0c20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/plugins/plugin-reload-data.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Sami
3 years, 8 months ago (2017-04-12 10:21:57 UTC) #5
Eric Seckler
lgtm
3 years, 8 months ago (2017-04-12 10:30:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273005/1
3 years, 8 months ago (2017-04-12 11:42:14 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 11:49:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a979e581c8d1585cb67062d29f9e...

Powered by Google App Engine
This is Rietveld 408576698