Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2808263004: Add a new WebAPK-specific app banner shortcut source. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 2e0c8abe1139f60ae7fc7950d9a99be77ef654ab..ac3b29e92b7eda71a5955393c3cde7386980cbb3 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -38,14 +38,18 @@ std::unique_ptr<ShortcutInfo> CreateShortcutInfo(
const GURL& manifest_url,
const content::Manifest& manifest,
const GURL& primary_icon_url,
- const GURL& badge_icon_url) {
+ const GURL& badge_icon_url,
+ bool is_webapk) {
auto shortcut_info = base::MakeUnique<ShortcutInfo>(GURL());
if (!manifest.IsEmpty()) {
shortcut_info->UpdateFromManifest(manifest);
shortcut_info->manifest_url = manifest_url;
shortcut_info->best_primary_icon_url = primary_icon_url;
shortcut_info->best_badge_icon_url = badge_icon_url;
- shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);
+ if (is_webapk)
+ shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER_WEBAPK);
+ else
+ shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);
}
shortcut_info->ideal_splash_image_size_in_px =
@@ -243,8 +247,8 @@ void AppBannerManagerAndroid::ShowBanner() {
if (AppBannerInfoBarDelegateAndroid::Create(
contents, GetWeakPtr(), app_title_,
CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
- badge_icon_url_),
- primary_icon_, badge_icon_, event_request_id(),
+ badge_icon_url_, can_install_webapk_),
+ primary_icon_, badge_icon_, event_request_id(), can_install_webapk_,
webapk::INSTALL_SOURCE_BANNER)) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.cc ('k') | chrome/browser/android/shortcut_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698