chrome/browser/android/banners/app_banner_infobar_delegate_android.cc - Issue 2808263004: Add a new WebAPK-specific app banner shortcut source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2808263004: Add a new WebAPK-specific app banner shortcut source. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

index ba01f68a4821503b130064a253e668a88dfd330a..2755e15d24f5591b3320cfc12529e6e52e386840 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

@@ -13,7 +13,6 @@

#include "chrome/browser/android/shortcut_helper.h"

#include "chrome/browser/android/shortcut_info.h"

#include "chrome/browser/android/tab_android.h"

-#include "chrome/browser/android/webapk/chrome_webapk_host.h"

#include "chrome/browser/android/webapk/webapk_install_service.h"

#include "chrome/browser/banners/app_banner_manager.h"

#include "chrome/browser/banners/app_banner_metrics.h"

@@ -55,8 +54,8 @@ bool AppBannerInfoBarDelegateAndroid::Create(

const SkBitmap& primary_icon,

const SkBitmap& badge_icon,

int event_request_id,

+ bool is_webapk,

webapk::InstallSource webapk_install_source) {

- bool is_webapk = ChromeWebApkHost::CanInstallWebApk();

const GURL url = shortcut_info->url;

auto infobar_delegate =

base::WrapUnique(new banners::AppBannerInfoBarDelegateAndroid(