Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2808253002: Tell MSan to ignore uninitialized padding when writing snapshots (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
vogelheim1, vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Tell MSan to ignore uninitialized padding when writing snapshots After r299061, MSan started complaining about uninitialized data in fwrite. BUG=chromium:710152 Review-Url: https://codereview.chromium.org/2808253002 Cr-Commit-Position: refs/heads/master@{#44587} Committed: https://chromium.googlesource.com/v8/v8/+/dd1e2e849939e1728910cf293bb2651c98a12dba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/snapshot/mksnapshot.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
hans
Please take a look.
3 years, 8 months ago (2017-04-10 23:59:41 UTC) #2
vogelheim1
lgtm. Thanks for diagnosing and fixing this!
3 years, 8 months ago (2017-04-11 08:58:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808253002/1
3 years, 8 months ago (2017-04-11 15:34:31 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-11 15:34:33 UTC) #8
hans
On 2017/04/11 15:34:33, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 8 months ago (2017-04-11 15:36:10 UTC) #9
vogelheim
lgtm (Yes, I used the wrong account. Sorry.)
3 years, 8 months ago (2017-04-11 15:38:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808253002/1
3 years, 8 months ago (2017-04-11 15:43:50 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:02:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dd1e2e849939e1728910cf293bb2651c98a...

Powered by Google App Engine
This is Rietveld 408576698