Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2808233002: [ARM] Assembler should assemble vzip/vuzp.32 as vtrn. (Closed)

Created:
3 years, 8 months ago by bbudge
Modified:
3 years, 8 months ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Assembler should assemble vzip/vuzp.32 as vtrn. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2808233002 Cr-Commit-Position: refs/heads/master@{#44690} Committed: https://chromium.googlesource.com/v8/v8/+/39f8e0c74a8e702d70c7fedb206ec385be80d0e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bbudge
3 years, 8 months ago (2017-04-10 22:27:21 UTC) #4
bbudge
We should land this to prevent invalid instructions from being assembled. PTAL
3 years, 8 months ago (2017-04-17 17:58:01 UTC) #7
martyn.capewell
lgtm
3 years, 8 months ago (2017-04-18 10:18:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808233002/1
3 years, 8 months ago (2017-04-18 14:05:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:30:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/39f8e0c74a8e702d70c7fedb206ec385be8...

Powered by Google App Engine
This is Rietveld 408576698