Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2808173004: Fixing type of returned user info object. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing type of returned user info object. BUG=652781 Review-Url: https://codereview.chromium.org/2808173004 Cr-Commit-Position: refs/heads/master@{#463427} Committed: https://chromium.googlesource.com/chromium/src/+/4ef01ce3af668d5abe41d0721f98933a549ad5af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/client/ios/domain/user_info.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
nicholss
PTAL, thanks!
3 years, 8 months ago (2017-04-10 21:47:22 UTC) #2
Jamie
LGTM, but is there anything we can do to make the compiler catch this sort ...
3 years, 8 months ago (2017-04-10 21:49:11 UTC) #3
nicholss
On 2017/04/10 21:49:11, Jamie wrote: > LGTM, but is there anything we can do to ...
3 years, 8 months ago (2017-04-10 21:51:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808173004/1
3 years, 8 months ago (2017-04-10 21:53:05 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:46:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ef01ce3af668d5abe41d0721f98...

Powered by Google App Engine
This is Rietveld 408576698