Prioritize analysis of files that import the changed file, or have an error or warning.

Prioritize analysis of files that import the changed file, or have an error or warning.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3dd42456e470135da729d1f800590a3d438e6082

[Paul Berry, 2017-04-10 18:08:50]

lgtm

[Brian Wilkerson, 2017-04-10 18:17:38]

lgtm

https://codereview.chromium.org/2808173002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_tracker.dart (right):

https://codereview.chromium.org/2808173002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_tracker.dart:201:
pendingFiles.addAll(_pendingFiles);
Are we sure we want to add previous pending files after indirect files? If they
were explicitly changed it seems like they should be analyzed before files that
*might* be effected by changes.

[scheglov, 2017-04-10 18:51:58]

https://codereview.chromium.org/2808173002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_tracker.dart (right):

https://codereview.chromium.org/2808173002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_tracker.dart:201:
pendingFiles.addAll(_pendingFiles);
On 2017/04/10 18:17:38, Brian Wilkerson wrote:
> Are we sure we want to add previous pending files after indirect files? If
they
> were explicitly changed it seems like they should be analyzed before files
that
> *might* be effected by changes.

Well, we would need a way to distinguish which files in existing pending queue
were added there because the were changed, from the files that were added
because they might be affected to a previously changed file. Probably we would
need two separate buckets - for pending changed files, and all other pending
files (imports, errors, the rest). I don't know if it is worth.

[scheglov, 2017-04-10 20:54:10]

PTAL

Brian, your comment made me realize that we have a problem with scheduling over
multiple driver instances. In order to analyze all changed files, then all files
that imports these files, them all files with errors - we need to know when
we're completely done with one bucket in *all* drivers, and then process other
buckets. So, using a single pendingFiles queue and single general priority does
not work - we need everything separated.

[Brian Wilkerson, 2017-04-10 20:58:21]

lgtm

[scheglov, 2017-04-11 15:26:32]

Description was changed from

==========
Prioritize analysis of files that import the changed file, or have an error or
warning.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Prioritize analysis of files that import the changed file, or have an error or
warning.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3dd42456e470135da729d1f800590a3d438e6082
==========

[scheglov, 2017-04-11 15:26:33]

Committed patchset #2 (id:20001) manually as
3dd42456e470135da729d1f800590a3d438e6082 (presubmit successful).