Prioritize analysis of files that import the changed file, or have an error or warning.

pkg/analyzer/lib/src/dart/analysis/driver.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:typed_data';
 
 import 'package:analyzer/context/context_root.dart';
 import 'package:analyzer/context/declared_variables.dart';
@@ skipping 391 matching lines @@
     if (_topLevelNameDeclarationsTasks.isNotEmpty) {
       return AnalysisDriverPriority.interactive;
     }
     if (_priorityFiles.isNotEmpty) {
       for (String path in _priorityFiles) {
         if (_fileTracker.isFilePending(path)) {
           return AnalysisDriverPriority.priority;
         }
       }
     }
+    if (_fileTracker.hasChangedFiles) {
+      return AnalysisDriverPriority.changedFiles;
+    }
+    if (_fileTracker.hasPendingChangedFiles) {
+      return AnalysisDriverPriority.generalChanged;
+    }
+    if (_fileTracker.hasPendingImportFiles) {
+      return AnalysisDriverPriority.generalImportChanged;
+    }
+    if (_fileTracker.hasPendingErrorFiles) {
+      return AnalysisDriverPriority.generalWithErrors;
+    }
     if (_fileTracker.hasPendingFiles) {
       return AnalysisDriverPriority.general;
     }
-    if (_fileTracker.hasChangedFiles) {
-      return AnalysisDriverPriority.general;
-    }
     if (_requestedParts.isNotEmpty || _partsToAnalyze.isNotEmpty) {
       return AnalysisDriverPriority.general;
     }
     return AnalysisDriverPriority.nothing;
   }
 
   /**
    * Add the file with the given [path] to the set of files to analyze.
    *
    * The [path] must be absolute and normalized.
@@ skipping 651 matching lines @@
 
   /**
    * Load the [AnalysisResult] for the given [file] from the [bytes]. Set
    * optional [content] and [resolvedUnit].
    */
   AnalysisResult _getAnalysisResultFromBytes(
       FileState file, String signature, List<int> bytes,
       {String content, CompilationUnit resolvedUnit}) {
     var unit = new AnalysisDriverResolvedUnit.fromBuffer(bytes);
     List<AnalysisError> errors = _getErrorsFromSerialized(file, unit.errors);
+    _updateHasErrorOrWarningFlag(file, errors);
     return new AnalysisResult(
         this,
         _sourceFactory,
         file.path,
         file.uri,
         file.exists,
         content,
         file.contentHash,
         file.lineInfo,
         signature,
@@ skipping 136 matching lines @@
       String sec = _twoDigits(time.second);
       String ms = _threeDigits(time.millisecond);
       String key = 'exception_${time.year}$m$d' '_$h$min$sec' + '_$ms';
 
       _byteStore.put(key, bytes);
       return key;
     } catch (_) {
       return null;
     }
   }
+
+  /**
+   * Given the list of [errors] for the [file], update the [file]'s
+   * [FileState.hasErrorOrWarning] flag.
+   */
+  void _updateHasErrorOrWarningFlag(
+      FileState file, List<AnalysisError> errors) {
+    for (AnalysisError error in errors) {
+      ErrorSeverity severity = error.errorCode.errorSeverity;
+      if (severity == ErrorSeverity.ERROR ||
+          severity == ErrorSeverity.WARNING) {
+        file.hasErrorOrWarning = true;
+        return;
+      }
+    }
+    file.hasErrorOrWarning = false;
+  }
 }
 
 /**
  * A generic schedulable interface via the AnalysisDriverScheduler. Currently
  * only implemented by [AnalysisDriver] and the angular plugin, at least as
  * a temporary measure until the official plugin API is ready (and a different
  * scheduler is used)
  */
 abstract class AnalysisDriverGeneric {
   /**
@@ skipping 15 matching lines @@
    * Perform a single chunk of work and produce [results].
    */
   Future<Null> performWork();
 }
 
 /**
  * Priorities of [AnalysisDriver] work. The farther a priority to the beginning
  * of the list, the earlier the corresponding [AnalysisDriver] should be asked
  * to perform work.
  */
-enum AnalysisDriverPriority { nothing, general, priority, interactive }
+enum AnalysisDriverPriority {
+  nothing,
+  general,
+  generalWithErrors,
+  generalImportChanged,
+  generalChanged,
+  changedFiles,
+  priority,
+  interactive
+}
 
 /**
  * Instances of this class schedule work in multiple [AnalysisDriver]s so that
  * work with the highest priority is performed first.
  */
 class AnalysisDriverScheduler {
   /**
    * Time interval in milliseconds before pumping the event queue.
    *
    * Relinquishing execution flow and running the event loop after every task
@@ skipping 696 matching lines @@
           libraryDeclarations.add(new TopLevelDeclarationInSource(
               file.source, declaration, isExported));
         }
       }
     }
 
     // We're not done yet.
     return false;
   }
 }