chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java - Issue 2808163002: [Android O] Refactor channel initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

Issue 2808163002: [Android O] Refactor channel initialization (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

index 5f6588f7b21064a666cea92a842dad1a6c720cbf..caf2d00dbb32b38b7a52eb90b58a33c4174a9baa 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java

@@ -20,6 +20,7 @@ import android.os.IBinder;

import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.notifications.ChannelsInitializer;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

import org.chromium.chrome.browser.notifications.NotificationConstants;

@@ -150,11 +151,8 @@ public class PhysicalWebBroadcastService extends Service {

(NotificationManager) getSystemService(NOTIFICATION_SERVICE));

ChromeNotificationBuilder notificationBuilder =

NotificationBuilderFactory

- .createChromeNotificationBuilder(true /* preferCompat */,

- NotificationConstants.CHANNEL_ID_BROWSER,

- context.getString(R.string.notification_category_browser),

- NotificationConstants.CHANNEL_GROUP_ID_GENERAL,

- context.getString(R.string.notification_category_group_general))

+ .createChromeNotificationBuilder(

+ true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_BROWSER)

.setSmallIcon(R.drawable.ic_image_white_24dp)

.setContentTitle(getString(R.string.physical_web_broadcast_notification))

.setContentText(displayUrl)