chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java - Issue 2808163002: [Android O] Refactor channel initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

Issue 2808163002: [Android O] Refactor channel initialization (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

index f5847694243472280dfe4ae4e9648bf5bfce4f36..1bc98b25070c016f85294f04a0711d5763947361 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

@@ -25,9 +25,9 @@ import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

+import org.chromium.chrome.browser.notifications.ChannelsInitializer;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

-import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationUmaTracker;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationAction;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationOptOut;

@@ -172,11 +172,8 @@ public class ContentSuggestionsNotificationHelper {

0);

ChromeNotificationBuilder builder =

NotificationBuilderFactory

- .createChromeNotificationBuilder(true /* preferCompat */,

- NotificationConstants.CHANNEL_ID_BROWSER,

- context.getString(R.string.notification_category_browser),

- NotificationConstants.CHANNEL_GROUP_ID_GENERAL,

- context.getString(R.string.notification_category_group_general))

+ .createChromeNotificationBuilder(

+ true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_BROWSER)

.setAutoCancel(true)

.setContentIntent(contentIntent)

.setDeleteIntent(deleteIntent)