[Sync] Post back to UI thread for USS GetAllNodes.

[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/model_type_controller.cc
that did the jump back to the UI thread. This meant that non-UI USS
types (namely AUTOFILL) were updating GetAllNodesRequestHelper from a
different thread, through very non-thread safe code. To fix simply
added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172
Review-Url: https://codereview.chromium.org/2808113003
Cr-Commit-Position: refs/heads/master@{#463320}
Committed: https://chromium.googlesource.com/chromium/src/+/903ebf3235f4057351f7734c0e148e7938009dbd

[skym, 2017-04-10 16:57:01]

Description was changed from

==========
[Sync] Post back to UI thread for USS GetAllNodes.

BUG=686172
==========

to

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access their
processor/bridge. This means after they've gathered the nodes, they need to
return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread. This meant that non-UI USS types
(namely AUTOFILL) were updating GetAllNodesRequestHelper from a different
thread, through very non-thread safe code. To fix simply added the
BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in hopes of
stopping similar bugs from occurring again.

BUG=686172
==========

[skym, 2017-04-10 16:57:01]

skym@chromium.org changed reviewers:
+ pavely@chromium.org

[skym, 2017-04-10 16:57:05]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-04-10 16:59:17]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org
- pavely@chromium.org

[skym, 2017-04-10 16:59:18]

PTAL

[maxbogue, 2017-04-10 17:02:51]

lgtm

[maxbogue, 2017-04-10 17:02:52]

lgtm

[skym, 2017-04-10 17:04:28]

Description was changed from

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access their
processor/bridge. This means after they've gathered the nodes, they need to
return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread. This meant that non-UI USS types
(namely AUTOFILL) were updating GetAllNodesRequestHelper from a different
thread, through very non-thread safe code. To fix simply added the
BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in hopes of
stopping similar bugs from occurring again.

BUG=686172
==========

to

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread.
This meant that non-UI USS types (namely AUTOFILL) were updating
GetAllNodesRequestHelper from a different thread, through very
non-thread safe code. To fix simply added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172
==========

[skym, 2017-04-10 17:05:02]

Description was changed from

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread.
This meant that non-UI USS types (namely AUTOFILL) were updating
GetAllNodesRequestHelper from a different thread, through very
non-thread safe code. To fix simply added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172
==========

to

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread. This meant that non-UI USS
types (namely AUTOFILL) were updating GetAllNodesRequestHelper from a
different thread, through very non-thread safe code. To fix simply
added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172
==========

[commit-bot: I haz the power, 2017-04-10 17:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:43:48]

Dry run: This issue passed the CQ dry run.

[skym, 2017-04-10 17:49:25]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:50:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:59:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491846565201070, "parent_rev":
"7d48b1ebf6fd1f326a7b437b438c05c7296ecaba", "commit_rev":
"903ebf3235f4057351f7734c0e148e7938009dbd"}

[commit-bot: I haz the power, 2017-04-10 18:00:30]

Description was changed from

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread. This meant that non-UI USS
types (namely AUTOFILL) were updating GetAllNodesRequestHelper from a
different thread, through very non-thread safe code. To fix simply
added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172
==========

to

==========
[Sync] Post back to UI thread for USS GetAllNodes.

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/...
that did the jump back to the UI thread. This meant that non-UI USS
types (namely AUTOFILL) were updating GetAllNodesRequestHelper from a
different thread, through very non-thread safe code. To fix simply
added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172

Review-Url: https://codereview.chromium.org/2808113003
Cr-Commit-Position: refs/heads/master@{#463320}
Committed:
https://chromium.googlesource.com/chromium/src/+/903ebf3235f4057351f7734c0e14...
==========

[commit-bot: I haz the power, 2017-04-10 18:00:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/903ebf3235f4057351f7734c0e14...