Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2808093008: Fix disabling FFMpeg video decoders on non-Android platforms (Closed)

Created:
3 years, 8 months ago by rduszynski
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix disabling FFMpeg video decoders on non-Android platforms If disable_ffmpeg_video_decoders is set to true on platfoms other than Android ffmped_video_decoder.* is always included. This patch removes those sources and fixes dependencies in code. Review-Url: https://codereview.chromium.org/2808093008 Cr-Commit-Position: refs/heads/master@{#464394} Committed: https://chromium.googlesource.com/chromium/src/+/ab15c62867108abf92582f3f6c41a766b10324c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M content/browser/media/media_internals.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/BUILD.gn View 4 chunks +18 lines, -18 lines 0 comments Download
M media/filters/decoder_selector.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
rduszynski
@reviewer Some changes were made with introduction of disable_ffmpeg_video_decoders, however not all non-Android specific paths ...
3 years, 8 months ago (2017-04-12 14:59:32 UTC) #3
jam
On 2017/04/12 14:59:32, rduszynski wrote: > @reviewer Some changes were made with introduction of > ...
3 years, 8 months ago (2017-04-12 17:25:49 UTC) #4
rduszynski
On 2017/04/12 17:25:49, jam wrote: > On 2017/04/12 14:59:32, rduszynski wrote: > > @reviewer Some ...
3 years, 8 months ago (2017-04-12 17:55:46 UTC) #6
chromium-reviews
On vacation this week. Try someone else (or wait until next week.) /Hubbe On Wed, ...
3 years, 8 months ago (2017-04-12 18:34:36 UTC) #7
DaleCurtis
lgtm, though I have the vague feeling this was done for some way that I ...
3 years, 8 months ago (2017-04-12 18:37:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808093008/1
3 years, 8 months ago (2017-04-13 11:33:36 UTC) #11
commit-bot: I haz the power
The author rduszynski@opera.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 8 months ago (2017-04-13 11:33:38 UTC) #13
Mostyn Bramley-Moore
On 2017/04/13 11:33:38, commit-bot: I haz the power wrote: > The author mailto:rduszynski@opera.com has not ...
3 years, 8 months ago (2017-04-13 12:23:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808093008/1
3 years, 8 months ago (2017-04-13 12:24:09 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 14:01:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab15c62867108abf92582f3f6c41...

Powered by Google App Engine
This is Rietveld 408576698