Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2808093005: Blink Rename follow-up: XHRs --big-rename--> _xh_rs --this-fix--> _xhrs. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Rename follow-up: XHRs --big-rename--> _xh_rs --this-fix--> _xhrs. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2808093005 Cr-Commit-Position: refs/heads/master@{#463866} Committed: https://chromium.googlesource.com/chromium/src/+/957973a1cdbd77c68547ca32ebd993b882c356be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Łukasz Anforowicz
caseq@, could you PTAL?
3 years, 8 months ago (2017-04-11 20:16:36 UTC) #5
caseq
lgtm
3 years, 8 months ago (2017-04-12 00:13:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808093005/1
3 years, 8 months ago (2017-04-12 00:44:36 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 01:18:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/957973a1cdbd77c68547ca32ebd9...

Powered by Google App Engine
This is Rietveld 408576698