Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2808073003: Image Capture: wire supported exposure/focus/white balance modes Android (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: wire supported exposure/focus/white balance modes Android This CL follows on the steps of [1] and wires the supported auto white balance/focus/exposure modes for the Android implementations -- whereas on ToT only the 'current' state of these features was collected. Manually tested using N7 and N6P and https://rawgit.com/Miguelao/demos/master/imagecapture.html [1] https://codereview.chromium.org/2806743003/ BUG=700607 Review-Url: https://codereview.chromium.org/2808073003 Cr-Commit-Position: refs/heads/master@{#463426} Committed: https://chromium.googlesource.com/chromium/src/+/c1c7111870c820080a0bc5953e3b6505058f07b5

Patch Set 1 : #

Total comments: 10

Patch Set 2 : reillyg@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -43 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java View 1 9 chunks +50 lines, -9 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCapture.java View 2 chunks +9 lines, -0 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 5 chunks +54 lines, -20 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 5 chunks +55 lines, -5 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/capture/video/android/photo_capabilities.cc View 4 chunks +51 lines, -0 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 4 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
mcasas
reillyg@ PTAL
3 years, 8 months ago (2017-04-10 16:11:08 UTC) #5
Reilly Grant (use Gerrit)
lgtm with nits https://codereview.chromium.org/2808073003/diff/20001/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java File media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java (right): https://codereview.chromium.org/2808073003/diff/20001/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java#newcode182 media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:182: return (focusModes != null) ? focusModes.clone() ...
3 years, 8 months ago (2017-04-10 18:01:49 UTC) #6
mcasas
https://codereview.chromium.org/2808073003/diff/20001/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java File media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java (right): https://codereview.chromium.org/2808073003/diff/20001/media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java#newcode182 media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:182: return (focusModes != null) ? focusModes.clone() : new int[0]; ...
3 years, 8 months ago (2017-04-10 19:53:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808073003/40001
3 years, 8 months ago (2017-04-10 19:55:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/154075)
3 years, 8 months ago (2017-04-10 21:55:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808073003/40001
3 years, 8 months ago (2017-04-10 22:04:17 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:44:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1c7111870c820080a0bc5953e3b...

Powered by Google App Engine
This is Rietveld 408576698