[regexp] Properly handle HeapNumbers in AdvanceStringIndex

[regexp] Properly handle HeapNumbers in AdvanceStringIndex

This fixes behavior for HeapNumber {index} arguments passed to
AdvanceStringIndex.

Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead
would result in a Smi addition on the tagged HeapNumber pointer.

Backmerge of commit ed5496f3cd1b410e1632531799edddfad8afe4f6.

BUG=chromium:709015
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2808033002
Cr-Commit-Position: refs/branch-heads/5.8@{#55}
Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429}
Committed: https://chromium.googlesource.com/v8/v8/+/bd8da83ff492de02d922abd5c08ad8f762bc7fba

[jgruber, 2017-04-10 14:13:00]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 14:13:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:13:11]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[jgruber, 2017-04-10 14:13:28]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org

[jgruber, 2017-04-10 14:14:25]

Description was changed from

==========
[regexp] Properly handle HeapNumbers in AdvanceStringIndex

This fixes behavior for HeapNumber {index} arguments passed to
AdvanceStringIndex.

Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead
would result in a Smi addition on the tagged HeapNumber pointer.

Backmerge of commit ed5496f3cd1b410e1632531799edddfad8afe4f6.

BUG=chromium:709015
==========

to

==========
[regexp] Properly handle HeapNumbers in AdvanceStringIndex

This fixes behavior for HeapNumber {index} arguments passed to
AdvanceStringIndex.

Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead
would result in a Smi addition on the tagged HeapNumber pointer.

Backmerge of commit ed5496f3cd1b410e1632531799edddfad8afe4f6.

BUG=chromium:709015
NOPRESUBMIT=true
NOTRY=true
==========

[Camillo Bruni, 2017-04-10 14:18:10]

lgtm

[jgruber, 2017-04-10 14:18:46]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:18:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:18:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491833926809520,
"parent_rev": "b88c1083f4ad4b85220392e3d5af11261128886c", "commit_rev":
"bd8da83ff492de02d922abd5c08ad8f762bc7fba"}

[commit-bot: I haz the power, 2017-04-10 14:19:04]

Description was changed from

==========
[regexp] Properly handle HeapNumbers in AdvanceStringIndex

This fixes behavior for HeapNumber {index} arguments passed to
AdvanceStringIndex.

Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead
would result in a Smi addition on the tagged HeapNumber pointer.

Backmerge of commit ed5496f3cd1b410e1632531799edddfad8afe4f6.

BUG=chromium:709015
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
[regexp] Properly handle HeapNumbers in AdvanceStringIndex

This fixes behavior for HeapNumber {index} arguments passed to
AdvanceStringIndex.

Previously, we'd blindly treat {index} as a Smi. Passing a HeapNumber instead
would result in a Smi addition on the tagged HeapNumber pointer.

Backmerge of commit ed5496f3cd1b410e1632531799edddfad8afe4f6.

BUG=chromium:709015
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2808033002
Cr-Commit-Position: refs/branch-heads/5.8@{#55}
Cr-Branched-From:
eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1}
Cr-Branched-From:
4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429}
Committed:
https://chromium.googlesource.com/v8/v8/+/bd8da83ff492de02d922abd5c08ad8f762b...
==========

[commit-bot: I haz the power, 2017-04-10 14:19:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bd8da83ff492de02d922abd5c08ad8f762b...