Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2808023002: [regexp] Ensure there are no shape changes on the fast path (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Camillo Bruni
CC:
v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

[regexp] Ensure there are no shape changes on the fast path Backmerge of commit ae459356468ae81955a1298acd255794ac901b4c and 1ccf6c0943e328183cb670e14d718b7461cbcb93. BUG=v8:5437, chromium:708247 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2808023002 Cr-Commit-Position: refs/branch-heads/5.8@{#56} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/b5de87fef565d5e264e9babdcc46742d1cfc7bd9

Patch Set 1 #

Patch Set 2 : Rebase and backmerge second part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -41 lines) Patch
M src/builtins/builtins-regexp.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 18 chunks +102 lines, -35 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-utils.cc View 1 chunk +8 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-6210.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-708247.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
jgruber
3 years, 8 months ago (2017-04-10 14:10:39 UTC) #12
Camillo Bruni
lgtm
3 years, 8 months ago (2017-04-10 14:18:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808023002/20001
3 years, 8 months ago (2017-04-10 14:21:10 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 14:21:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b5de87fef565d5e264e9babdcc46742d1cf...

Powered by Google App Engine
This is Rietveld 408576698