Resolve promises synchronously sometimes

Resolve promises synchronously sometimes

https://codereview.chromium.org/2615253002 changed
~PlayStateUpdateScope() to resolve promises asynchronously in order to
avoid script execution inside a forbidden scope. However, this causes
the promises to behave differently from expected in some cases,
demonstrated in part by a crash in the interfaces/Animation/cancel.html
test due to failing a DCHECK.

This patch modifies the promise resolution code to first check whether
we are in a forbidden scope, and only resolve the promise asynchronously
if so.

BUG=708887
Review-Url: https://codereview.chromium.org/2808013002
Cr-Commit-Position: refs/heads/master@{#463907}
Committed: https://chromium.googlesource.com/chromium/src/+/220578cfcb90370db3b268c6e59c1c4417a60708

[suzyh_UTC10 (ex-contributor), 2017-04-10 07:11:37]

suzyh@chromium.org changed reviewers:
+ adithyas@chromium.org, dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-10 07:11:42]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 07:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 08:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 08:27:57]

Dry run: This issue passed the CQ dry run.

[adithyas, 2017-04-10 14:42:54]

lgtm

lgtm

[suzyh_UTC10 (ex-contributor), 2017-04-10 23:16:10]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org
- dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-10 23:16:30]

-dstockwell (OOO) +alancutter

[alancutter (OOO until 2018), 2017-04-11 06:52:18]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-04-12 00:47:10]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-04-12 00:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:41:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491958030394330, "parent_rev":
"a1f827118b1b305b7f1c9afbcad9e72e07daca74", "commit_rev":
"220578cfcb90370db3b268c6e59c1c4417a60708"}

[commit-bot: I haz the power, 2017-04-12 02:41:57]

Description was changed from

==========
Resolve promises synchronously sometimes

https://codereview.chromium.org/2615253002 changed
~PlayStateUpdateScope() to resolve promises asynchronously in order to
avoid script execution inside a forbidden scope. However, this causes
the promises to behave differently from expected in some cases,
demonstrated in part by a crash in the interfaces/Animation/cancel.html
test due to failing a DCHECK.

This patch modifies the promise resolution code to first check whether
we are in a forbidden scope, and only resolve the promise asynchronously
if so.

BUG=708887
==========

to

==========
Resolve promises synchronously sometimes

https://codereview.chromium.org/2615253002 changed
~PlayStateUpdateScope() to resolve promises asynchronously in order to
avoid script execution inside a forbidden scope. However, this causes
the promises to behave differently from expected in some cases,
demonstrated in part by a crash in the interfaces/Animation/cancel.html
test due to failing a DCHECK.

This patch modifies the promise resolution code to first check whether
we are in a forbidden scope, and only resolve the promise asynchronously
if so.

BUG=708887

Review-Url: https://codereview.chromium.org/2808013002
Cr-Commit-Position: refs/heads/master@{#463907}
Committed:
https://chromium.googlesource.com/chromium/src/+/220578cfcb90370db3b268c6e59c...
==========

[commit-bot: I haz the power, 2017-04-12 02:42:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/220578cfcb90370db3b268c6e59c...