Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2807973004: Deflake two layout tests (Closed)

Created:
3 years, 8 months ago by rhogan
Modified:
3 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake two layout tests Ensure the image has loaded before testing layout. TBR=eae@chromium.org BUG=707918 Review-Url: https://codereview.chromium.org/2807973004 Cr-Commit-Position: refs/heads/master@{#463343} Committed: https://chromium.googlesource.com/chromium/src/+/be2222edd8ec874f2b200202f7450f34d1f8f017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-hidden-content-in-cell.html View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-visible-content-in-cell.html View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
rhogan
3 years, 8 months ago (2017-04-10 17:25:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807973004/1
3 years, 8 months ago (2017-04-10 18:39:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/be2222edd8ec874f2b200202f7450f34d1f8f017
3 years, 8 months ago (2017-04-10 18:55:55 UTC) #13
eae
3 years, 8 months ago (2017-04-10 18:58:02 UTC) #14
Message was sent while issue was closed.
LGTM, yay!

Powered by Google App Engine
This is Rietveld 408576698