third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp - Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp ('K') | « third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp ('k') | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

index 78dea66626650db17f55dd143817340770044d42..f71b454359d6cc4d1c9895d1723a7dd261963228 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

@@ -120,7 +120,7 @@ bool DecodingImageGenerator::onGetYUV8Planes(const SkYUVSizeInfo& sizeInfo,

void* planes[3]) {

// YUV decoding does not currently support progressive decoding. See comment

// in ImageFrameGenerator.h.

- ASSERT(m_canYUVDecode && m_allDataReceived);

+ DCHECK(m_canYUVDecode && m_allDataReceived);

tkent 2017/04/09 23:17:27 Split this into two DCHECKs.

Hwanseung Lee 2017/04/11 22:24:10 Done.

TRACE_EVENT1("blink", "DecodingImageGenerator::getYUV8Planes", "frame index",

static_cast<int>(m_frameIndex));