third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp - Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('K') | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp » ('j') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

index 5d68f6662c35cf7581d73c3c0fc1f32748136473..898d6b70ce58f5fc9b1f368b0de5c78f0fe34cd0 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

@@ -316,8 +316,8 @@ sk_sp<SkImage> DeferredImageDecoder::createFrameImageAtIndex(

size_t index,

bool knownToBeOpaque) {

const SkISize& decodedSize = m_frameGenerator->getFullSize();

- ASSERT(decodedSize.width() > 0);

- ASSERT(decodedSize.height() > 0);

+ DCHECK_GT(decodedSize.width(), 0);

+ DCHECK_GT(decodedSize.height(), 0);

sk_sp<SkROBuffer> roBuffer(m_rwBuffer->newRBufferSnapshot());

RefPtr<SegmentReader> segmentReader =