Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
index f749b50fd975e61ac8a3130b202fc7cc9104abc4..07603b4565e5bc56db4518e5adeafb9214f19a18 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
@@ -72,7 +72,7 @@ class HarfBuzzScopedPtr {
HarfBuzzScopedPtr(T* ptr, DestroyFunction destroy)
: m_ptr(ptr), m_destroy(destroy) {
- ASSERT(m_destroy);
+ DCHECK(m_destroy);
}
~HarfBuzzScopedPtr() {
if (m_ptr)
@@ -256,7 +256,7 @@ bool HarfBuzzShaper::extractShapeResults(RangeData* rangeData,
}
// Here we need to put character positions.
- ASSERT(numCharacters);
+ DCHECK(numCharacters);
rangeData->holesQueue.push_back(
HolesQueueItem(HolesQueueRange, startIndex, numCharacters));
}
@@ -311,7 +311,7 @@ bool HarfBuzzShaper::collectFallbackHintChars(
break;
UChar32 hintChar;
- RELEASE_ASSERT(it->m_startIndex + it->m_numCharacters <= m_textLength);
+ CHECK_LE(it->m_startIndex + it->m_numCharacters, m_textLength);
UTF16TextIterator iterator(m_text + it->m_startIndex, it->m_numCharacters);
while (iterator.consume(hintChar)) {
hint.push_back(hintChar);

Powered by Google App Engine
This is Rietveld 408576698