third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm ('K') | « third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

index 3f5674690f899584ce0e17f89b81b85162d47b87..14c3bcc0ae9b2b785bb1bbfb63c6ef7ace7d6d84 100644

--- a/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp

@@ -244,7 +244,7 @@ void OpenTypeVerticalData::getVerticalTranslationsForGlyphs(

size_t count,

float* outXYArray) const {

size_t countWidths = m_advanceWidths.size();

- ASSERT(countWidths > 0);

+ DCHECK_GT(countWidths, 0u);

const FontMetrics& metrics = font->getFontMetrics();

float sizePerUnit = font->sizePerUnit();

float ascent = metrics.ascent();