third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm ('K') | « third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm ('k') | third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm

diff --git a/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm b/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm

index f109e474d78ff8dce06843c9eac28179da37b79f..e1ddb867aad0c007528ad977cf4cd4d61ec44315 100644

--- a/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm

+++ b/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm

@@ -82,7 +82,7 @@ static sk_sp<SkTypeface> loadFromBrowserProcess(NSFont* nsFont,

// This function should only be called in response to an error loading a

// font due to being blocked by the sandbox.

// This by definition shouldn't happen if there is no sandbox support.

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return nullptr;

}