Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
index 14b1692d1d2bebb2b1d9e165848f9331dadea267..cfbf64cf22bcc4695bcfcb99abbba7d753094af8 100644
--- a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
@@ -123,7 +123,7 @@ PassRefPtr<FontDataForRangeSet> FontFallbackIterator::next(
return adoptRef(new FontDataForRangeSetFromCache(lastResort));
}
- ASSERT(m_fallbackStage == FontGroupFonts || m_fallbackStage == SegmentedFace);
+ DCHECK(m_fallbackStage == FontGroupFonts || m_fallbackStage == SegmentedFace);
const FontData* fontData =
m_fontFallbackList->fontDataAt(m_fontDescription, m_currentFontDataIndex);
@@ -162,7 +162,7 @@ PassRefPtr<FontDataForRangeSet> FontFallbackIterator::next(
m_fallbackStage = SegmentedFace;
}
- ASSERT(m_segmentedFaceIndex < segmented->numFaces());
+ DCHECK_LT(m_segmentedFaceIndex, segmented->numFaces());
RefPtr<FontDataForRangeSet> currentSegmentedFace =
segmented->faceAt(m_segmentedFaceIndex);
m_segmentedFaceIndex++;

Powered by Google App Engine
This is Rietveld 408576698