third_party/WebKit/Source/platform/fonts/Font.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Font.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/Font.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/Font.cpp b/third_party/WebKit/Source/platform/fonts/Font.cpp

index 2d9752f362ae77cd4fa7390a238903bba647f611..57a698dc196b814c3a8af97df300e9a558898d0b 100644

--- a/third_party/WebKit/Source/platform/fonts/Font.cpp

+++ b/third_party/WebKit/Source/platform/fonts/Font.cpp

@@ -159,7 +159,7 @@ bool Font::drawBidiText(PaintCanvas* canvas,

// sub-run painting is not supported for Bidi text.

const TextRun& run = runInfo.run;

- ASSERT((runInfo.from == 0) && (runInfo.to == run.length()));

+ DCHECK((runInfo.from == 0) && (runInfo.to == run.length()));

tkent 2017/04/09 23:13:23 Split this into two DCHECK_EQs

Hwanseung Lee 2017/04/11 22:25:09 Done.

BidiResolver<TextRunIterator, BidiCharacterRun> bidiResolver;

bidiResolver.setStatus(

BidiStatus(run.direction(), run.directionalOverride()));