Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
index 06f615c70b7a03034c84925e1c6af6f97b2ed4c4..21a22b66cb7530b813e7a9944f7aed410d4f5aeb 100644
--- a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
@@ -77,7 +77,7 @@ PassRefPtr<SimpleFontData> FontDataCache::get(
}
if (!result.get()->value.second) {
- ASSERT(m_inactiveFontData.contains(result.get()->value.first));
+ DCHECK(m_inactiveFontData.contains(result.get()->value.first));
m_inactiveFontData.erase(result.get()->value.first);
}
@@ -98,14 +98,14 @@ bool FontDataCache::contains(const FontPlatformData* fontPlatformData) const {
}
void FontDataCache::release(const SimpleFontData* fontData) {
- ASSERT(!fontData->isCustomFont());
+ DCHECK(!fontData->isCustomFont());
Cache::iterator it = m_cache.find(&(fontData->platformData()));
- ASSERT(it != m_cache.end());
+ DCHECK_NE(it, m_cache.end());
if (it == m_cache.end())
return;
- ASSERT(it->value.second);
+ DCHECK(it->value.second);
if (!--it->value.second)
m_inactiveFontData.insert(it->value.first);
}

Powered by Google App Engine
This is Rietveld 408576698