Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2807853002: Log metrics for loading SQLiteChannelIDStore (Closed)

Created:
3 years, 8 months ago by nharper
Modified:
3 years, 8 months ago
Reviewers:
vanupam, Steven Holte, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log metrics for loading SQLiteChannelIDStore BUG=548423 Review-Url: https://codereview.chromium.org/2807853002 Cr-Commit-Position: refs/heads/master@{#463437} Committed: https://chromium.googlesource.com/chromium/src/+/9d64fcad3c27082ef8c94a54e41ebe30337e37b1

Patch Set 1 #

Total comments: 4

Patch Set 2 : respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -2 lines) Patch
M net/extras/sqlite/sqlite_channel_id_store.cc View 1 8 chunks +45 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nharper
3 years, 8 months ago (2017-04-07 23:46:50 UTC) #2
mattm
https://codereview.chromium.org/2807853002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc File net/extras/sqlite/sqlite_channel_id_store.cc (right): https://codereview.chromium.org/2807853002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc#newcode261 net/extras/sqlite/sqlite_channel_id_store.cc:261: if (!key) Should this be recorded somehow? https://codereview.chromium.org/2807853002/diff/1/tools/metrics/histograms/histograms.xml File ...
3 years, 8 months ago (2017-04-08 04:17:38 UTC) #3
nharper
https://codereview.chromium.org/2807853002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc File net/extras/sqlite/sqlite_channel_id_store.cc (right): https://codereview.chromium.org/2807853002/diff/1/net/extras/sqlite/sqlite_channel_id_store.cc#newcode261 net/extras/sqlite/sqlite_channel_id_store.cc:261: if (!key) On 2017/04/08 04:17:38, mattm wrote: > Should ...
3 years, 8 months ago (2017-04-10 19:29:49 UTC) #5
Steven Holte
lgtm
3 years, 8 months ago (2017-04-10 21:15:30 UTC) #6
mattm
lgtm
3 years, 8 months ago (2017-04-10 21:42:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807853002/20001
3 years, 8 months ago (2017-04-10 22:03:18 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 23:13:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d64fcad3c27082ef8c94a54e41e...

Powered by Google App Engine
This is Rietveld 408576698