Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ios/chrome/browser/web/BUILD.gn

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)
Patch Set: Attempt to fix build dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/sad_tab/sad_tab_view.mm ('k') | ios/chrome/browser/web/sad_tab_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/BUILD.gn
diff --git a/ios/chrome/browser/web/BUILD.gn b/ios/chrome/browser/web/BUILD.gn
index 6cd5023e0c1434e6016354d28d3d89ac53a502eb..dbde86c90e7d4dd9c63d1075d4414a4bd0d93e92 100644
--- a/ios/chrome/browser/web/BUILD.gn
+++ b/ios/chrome/browser/web/BUILD.gn
@@ -15,12 +15,16 @@ source_set("web") {
"network_activity_indicator_tab_helper.mm",
"repost_form_tab_helper.h",
"repost_form_tab_helper.mm",
+ "sad_tab_tab_helper.h",
+ "sad_tab_tab_helper.mm",
]
deps = [
+ ":sad_tab_tab_helper_delegate",
"//base",
"//components/strings",
"//ios/chrome/browser/ui",
"//ios/chrome/browser/ui/alert_coordinator:alert_coordinator",
+ "//ios/chrome/browser/ui/sad_tab:sad_tab",
"//ios/chrome/browser/ui/util:util",
"//ios/web",
"//ios/web:web_arc",
@@ -28,6 +32,13 @@ source_set("web") {
]
}
+source_set("sad_tab_tab_helper_delegate") {
+ configs += [ "//build/config/compiler:enable_arc" ]
+ sources = [
+ "sad_tab_tab_helper_delegate.h",
+ ]
+}
+
source_set("unit_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
@@ -35,8 +46,10 @@ source_set("unit_tests") {
"navigation_manager_util_unittest.mm",
"network_activity_indicator_tab_helper_unittest.mm",
"repost_form_tab_helper_unittest.mm",
+ "sad_tab_tab_helper_unittest.mm",
]
deps = [
+ ":sad_tab_tab_helper_delegate",
":web",
"//base:base",
"//base/test:test_support",
« no previous file with comments | « ios/chrome/browser/ui/sad_tab/sad_tab_view.mm ('k') | ios/chrome/browser/web/sad_tab_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698